fix: remove NTP servers by default - #855
Merged
Merged
Conversation
Member
|
Please squash all the commits into one. |
Member
|
Does this conflict with #821 ? |
Contributor
Author
|
Sorry I sent code to the wrong place initially... Squashed to a single commit, and brought the merging repo up to date. Doesn't conflict with #821, actually we are depending on that. Likely that commit is what added this regression, as previously we wouldn't have had any conflict between the Windows provided time, and the time coming via the previous NTP service. |
Contributor
|
Nice find. |
nzbr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #854
By default we only want to the "PHC0" provided via WSL, meaning we don't need to spend time reaching out to NTP servers, or conflicts that can happen with differing time.
In forked repository enabled the workflows. Passed builds, checks and tests. The exception was docs due to GitHub Pages being disabled by default.